DDP Error Meteor v3

dokithonon · March 10, 2024, 1:37pm

Hello,
I am migrating and testing my app to Meteor v3

I have sometimes this error :

if (this === DDPServer._getCurrentFence()) throw Error("Can't arm the current fence");

Do you know what is causing this ?

grubba · March 11, 2024, 2:00pm

Hey @dokithonon do you have a scenario when this happens? A reproduction would help us a lot there!

Also, thanks a lot for testing Meteor v3-beta!

dokithonon · March 12, 2024, 6:58am

Thanks for your reply.
This happens randomly when I update my code in development. I cannot reproduce it in a fresh new todo-app.
I will let you know if I can find a pattern that lead to the error.

pbeato · March 12, 2024, 6:59am

I have the same problem in my application. I am trying to systematically reproduce the problem but it is not easy. Can anyone explain what the error is referring to and what it may depend on, so you can help us simulate it. Thank you

paulishca · March 12, 2024, 9:34am

github.com

meteor/meteor/blob/2809237355e43128836131182a070eef20356e3e/packages/ddp-server/writefence.js#L54


      
                  throw new Error("committed called twice on the same write");
                committed = true;
                self.outstanding_writes--;
                self._maybeFire();
              }
            };
          },
          
          // Arm the fence. Once the fence is armed, and there are no more
          // uncommitted writes, it will activate.
          arm: function () {
            var self = this;
            if (self === DDPServer._CurrentWriteFence.get())
              throw Error("Can't arm the current fence");
            self.armed = true;
            self._maybeFire();
          },
          
          // Register a function to be called once before firing the fence.
          // Callback function can add new writes to the fence, in which case
          // it won't fire until those writes are done as well.

And a post about the fence: Meteor Explained and methods mechanisms - #2 by coagmano

dokithonon · March 12, 2024, 1:00pm

It appears quite a lot and this makes impossible to test meteor 3.
I am happy to do a screen sharing with anyone willing to help

dokithonon · March 12, 2024, 3:14pm

I am wondering if this line is not causing the fail :

packages/accounts-base/accounts_server.js:455:25

github.com

meteor/meteor/blob/master/packages/accounts-base/accounts_server.js

import crypto from 'crypto';
import { Meteor } from 'meteor/meteor'
import {
  AccountsCommon,
  EXPIRE_TOKENS_INTERVAL_MS,
} from './accounts_common.js';
import { URL } from 'meteor/url';

const hasOwn = Object.prototype.hasOwnProperty;

// XXX maybe this belongs in the check package
const NonEmptyString = Match.Where(x => {
  check(x, String);
  return x.length > 0;
});

/**
 * @summary Constructor for the `Accounts` namespace on the server.
 * @locus Server
 * @class AccountsServer

This file has been truncated. show original

I have a constant warning in Meteor v2.15 so I suppose when I update to Meteor v3. It fails.

denyhs · March 13, 2024, 2:28pm

Even if it isn’t directly related to this line, it needs to be fixed. I’ll add this to our backlog.

Regarding the error, we need to find a way to reproduce it. I’ll also have a look at this.

denyhs · March 13, 2024, 2:30pm

Just checked this code in our current branch, and it’s already fixed there.

Are you having this issue on beta 6?

zodern · March 13, 2024, 2:42pm

@denyhs if you run the tests in this branch of montiapm:agent, this error appears many times in the server logs. It seems like it is a bug with Meteor EnvironmentVariables.

dokithonon · March 13, 2024, 2:57pm

Yes beta 6. I have added Monti app on localhost and they also are logged into the apm

dokithonon · March 21, 2024, 5:02pm

Hello,
I still have this problem which prevents me from testing the meteor 3 beta version.
I have removed the package montiapm:agent but the error is still there

dokithonon · March 26, 2024, 2:58pm

It seems that this is solved with meteor 3 beta 7

Maybe it was related to this fix : Subscribe stop crash by perbergland · Pull Request #13034 · meteor/meteor · GitHub

denyhs · March 26, 2024, 8:43pm

That’s good news!

Is it working even with montiapm:agent?

dokithonon · March 27, 2024, 6:53am

Hello,
I have just added montiapm:agent

which leads to the following packages :

And this seems to work !
Thanks for your work