Stuff to be removed in Meteor 2.0

harry97 · October 2, 2020, 12:40pm

Maybe here?

meteor/meteor/blob/444f8228b8a46d1035095d606933893e1873b8c3/packages/accounts-base/accounts_server.js#L1112



  this._validateNewUserHooks.forEach(hook => {
    if (! hook(fullUser))
      throw new Meteor.Error(403, "User validation failed");
  });

  let userId;
  try {
    userId = this.users.insert(fullUser);
  } catch (e) {
    // XXX string parsing sucks, maybe
    // https://jira.mongodb.org/browse/SERVER-3069 will get fixed one day
    if (!e.errmsg) throw e;
    if (e.errmsg.includes('emails.address'))
      throw new Meteor.Error(403, "Email already exists.");
    if (e.errmsg.includes('username'))
      throw new Meteor.Error(403, "Username already exists.");
    throw e;
  }
  return userId;
};

storyteller · October 2, 2020, 12:40pm

Yes! Stuff like this.

jkuester · October 3, 2020, 10:18am

Maybe it would be good to make an inquiry on the Meteor releases that are running in production to see how far backwards-compatibility really needs to be done. Also keep in mind, that some older versions may miss important security fixes and should be considered vulnerable (especially all those using allow/deny…).

Maybe combined with some insights from the Galaxy team?

peterfkruger · October 3, 2020, 10:48am

That’s a smart idea indeed.

storyteller · October 15, 2020, 3:18pm

Speaking of 2.0:

github.com/meteor/meteor

Release 2.0

meteor:master ← meteor:release-2.0

opened 05:26PM - 14 Oct 20 UTC

filipenevola

+2795 -360

Meteor 2.0 is coming. We have big features coming like Hot Module Replacement… and Tree-shaking. We are not planning any breaking change but as these features are expected for a long time and they require a lot of changes in the internals we have decided it's the perfect timing for a major bump. Also, you should expect more major bumps in the future, we don't want to hold Meteor in a major version for years like it was with Meteor 1. Very soon we are going to start a new beta of Meteor 2.0. --- Update 2021/01/12: Tree-shaking [implementation](https://github.com/meteor/meteor/pull/11164) is going well (tests are passing) but we still have some bug reports to fix and performance optimizations to do, so we are moving it to Meteor 2.1 as we don't want to hold HMR and Meteor free deploy including MongoDB any longer. As we know Tree-shaking is not an easy task but we are close. --- Update 2021/01/17: We are also working to have Node.js 14 in a new version soon.

robfallows · October 15, 2020, 3:20pm

Mmmm. Interesting …

storyteller · October 15, 2020, 3:20pm

Probably an easy task to get few PRs in, removing some of these old code blocks.

storyteller · October 28, 2020, 7:23pm

Started work on removing stuff that was deprecated before Meteor v1.0.