A method named '/${collectionName}/update' is already defined

aureooms · August 30, 2021, 4:43pm

I recently hit an interesting edge case: defining methods /${collectionName}/update clashes with predefined methods (insert and remove also clash). Relevant lines are

github.com

meteor/meteor/blob/3427057e07e77d8763545472232b0b9fbd9f2f16/packages/allow-deny/allow-deny.js#L101-L124

    
      
          // XXX Think about method namespacing. Maybe methods should be
          // "Meteor:Mongo:insert/NAME"?
          self._prefix = '/' + self._name + '/';
          
          
// Mutation Methods
          // Minimongo on the server gets no stubs; instead, by default
          // it wait()s until its result is ready, yielding.
          // This matches the behavior of macromongo on the server better.
          // XXX see #MeteorServerNull
          if (self._connection && (self._connection === Meteor.server || Meteor.isClient)) {
            const m = {};
          
          
  ['insert', 'update', 'remove'].forEach((method) => {
              const methodName = self._prefix + method;
          
          
    if (options.useExisting) {
                const handlerPropName = Meteor.isClient ? '_methodHandlers' : 'method_handlers';
                // Do not try to create additional methods if this has already been called.
                // (Otherwise the .methods() call below will throw an error.)
                if (self._connection[handlerPropName] &&

This file has been truncated. show original

Hence, I have to name my methods differently. Any recommendation on method naming? I am now wrapping all methods in some object similar to what you can achieve with validated methods, so method names are not baked in as magic strings anymore. I do not want to allow calling a method by its name in code. Is it still advisable to give methods intelligible names?

filipenevola · August 31, 2021, 3:49am

If you avoid / (slash) you are going to already avoid these clashes.

Like links.insert for adding data to links

I already worked in a project using links#insert but I prefer .