Adding too many assets: Some assets don't get bundled

narzerus · December 8, 2016, 5:17pm

Is there a limit to the amount of assets you can add to a package via addAssets? We have this very weird use-case in my company where we need to compile styles in runtime, meaning we need the assets available for the server to read from. But after a certain amount of style files added with addAssets some files started being ignored by the build process.

Is anyone aware of this? Is this a bug or a limit by design?

Cheers and thanks in advance,
Rafael

lucfranken · December 9, 2016, 9:12am

What kind of numbers are you talking about? 100’s / 1000’s of files?

robfallows · December 9, 2016, 11:46am

It’s the _addFiles method in the isobuilder which is responsible for pushing the assets onto an array of assets. I can’t see any hardcoded limits here. However, it does look like it’s possible to fool the method with Unix-like pathnames on Windows machines.

github.com

meteor/meteor/blob/f4abbccf4570179f14d37a8747ceb391e25f1cb5/tools/isobuild/package-api.js#L402-L418


addAssets(paths, arch) {
  if(!arch) {
    buildmessage.error('addAssets requires a second argument specifying ' +
      'where the asset should be available. For example: "client", ' +
      '"server", or ["client", "server"].', { useMyCaller: true });
    return;
  }


  // Watch out - we rely on the levels of stack traces inside this
  // function so don't wrap it in another function without changing that logic
  this._addFiles("assets", paths, arch);
},


/**
 * Internal method used by addFiles and addAssets.
 */
_addFiles(type, paths, arch, fileOptions) {

narzerus · December 9, 2016, 1:00pm

Less than 1000 probably more than 100

narzerus · December 9, 2016, 1:01pm

Hmm, I’m gonna try to repro this in a new repo and post it here.

narzerus · December 15, 2016, 11:35am

Found the issue, got repro repo:

lucfranken · December 15, 2016, 2:45pm

It think:

This is a known issue. Files which are the same are not added 2 times, they are de-duplicated.

See for example:

It should not be an issue if you use the normal getters for the assets. They handle this so you can still load the files on the same path.