Calling method users.findOne from old API on server. accounts-base

dokithonon · June 25, 2024, 12:11pm

Hello,

In Meteor 2.16 I receive a lot of deprecation warnings

W20240625-14:05:48.430(2)? (STDERR)    Calling method users.findOne from old API on server.
W20240625-14:05:48.430(2)? (STDERR)    This method will be removed, from the server, in version 3.
W20240625-14:05:48.430(2)? (STDERR)    Trace is below:
W20240625-14:05:48.430(2)? (STDERR) [object Object]
W20240625-14:05:48.431(2)? (STDERR)     at warnUsingOldApi (packages/mongo/collection.js:21:13)
W20240625-14:05:48.431(2)? (STDERR)     at Collection.findOne (packages/mongo/collection.js:448:5)
W20240625-14:05:48.431(2)? (STDERR)     at MethodInvocation.defaultResumeLoginHandler (packages/accounts-base/accounts_server.js:1563:29)
W20240625-14:05:48.431(2)? (STDERR)     at MethodInvocation.<anonymous> (packages/accounts-base/accounts_server.js:1547:38)
W20240625-14:05:48.431(2)? (STDERR)     at MethodInvocation.<anonymous> (packages/meteor.js:365:18)
W20240625-14:05:48.431(2)? (STDERR)     at packages/accounts-base/accounts_server.js:589:31
W20240625-14:05:48.431(2)? (STDERR)     at /Users/dokithonon/.meteor/packages/promise/.0.12.2.undgfo.m3w8++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
W20240625-14:05:48.436(2)? (STDERR) 
W20240625-14:05:48.436(2)? (STDERR)    
W20240625-14:05:48.436(2)? (STDERR)    Calling method users.findOne from old API on server.
W20240625-14:05:48.436(2)? (STDERR)    This method will be removed, from the server, in version 3.
W20240625-14:05:48.436(2)? (STDERR)    Trace is below:
W20240625-14:05:48.437(2)? (STDERR) [object Object]
W20240625-14:05:48.437(2)? (STDERR)     at warnUsingOldApi (packages/mongo/collection.js:21:13)
W20240625-14:05:48.437(2)? (STDERR)     at Collection.findOne (packages/mongo/collection.js:448:5)
W20240625-14:05:48.437(2)? (STDERR)     at packages/accounts-base/accounts_server.js:455:25
W20240625-14:05:48.437(2)? (STDERR)     at /Users/dokithonon/.meteor/packages/promise/.0.12.2.undgfo.m3w8++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40

This is due to the use of findOne instead of findOneAsync on the server here :

github.com

meteor/meteor/blob/master/packages/accounts-base/accounts_server.js#L1563


      
          if (!options.resume)
            return undefined;
          
          check(options.resume, String);
          
          const hashedToken = accounts._hashLoginToken(options.resume);
          
          // First look for just the new-style hashed login token, to avoid
          // sending the unhashed token to the database in a query if we don't
          // need to.
          let user = accounts.users.findOne(
            {"services.resume.loginTokens.hashedToken": hashedToken},
            {fields: {"services.resume.loginTokens.$": 1}});
          
          if (! user) {
            // If we didn't find the hashed login token, try also looking for
            // the old-style unhashed token.  But we need to look for either
            // the old-style token OR the new-style token, because another
            // client connection logging in simultaneously might have already
            // converted the token.
            user = accounts.users.findOne({

Is this something you consider improving for v 2.17 ?

Thanks

leonardoventurini · June 25, 2024, 9:21pm

We can consider adding an environment variable or something, will discuss this with the team.

rjdavid · June 26, 2024, 4:32am

And, at the very least, ensure that the core packages have been migrated before displaying any deprecated warnings.

Anyway, instead of an environment variable, can we implement it as a setting for the MongoDB package?

leonardoventurini · June 26, 2024, 6:08pm

That’s an option we will consider. Thank you!