Creating a Pull Request for a Meteor Package?

help
1

I’ve got everything else working, as far as I can tell at this time, with rspack and Meteor 3.4beta11, except for Meteor.loginWithPassword. So I thought I’d see if I could create a pull request.

First thing of course is to get the relevant packages (accounts-base and accounts-password) running in my /packages folder, rather than in the `.meteor/packages’ folder, so I can edit and run them them.

I downloaded the Meteor source from github and copied the folders for accounts-base and accounts-password from it into a folder named “packages” at the root of the directory of my web app. But during build I get this error:

While selecting package versions:
   error: No version of accounts-base satisfies all constraints: @=3.1.2,
   @~3.2.0-beta340.11
   Constraints on package "accounts-base":
   * accounts-base@=3.1.2 <- top level
   * accounts-base@~3.2.0-beta340.11 <- top level
   * accounts-base@1.2.7 <- apollo 0.0.1
   * accounts-base@3.0.0 <- service-configuration 1.3.5 <- oauth 3.0.2 <-
   oauth2 1.3.3
   * accounts-base@3.0.0 <- service-configuration 1.3.5 <- oauth2 1.3.3
   * accounts-base@3.0.1 <- accounts-2fa 3.0.1

Here’s what’s in my .meteor/packages file:

[.....]
accounts-password@3.2.1
accounts-base

What am I missing?

Tagging @nachocodoner :slight_smile:

2

just “upgrade” your local accounts package to @~3.2.0-beta340.11 or 3.2.0. You this by changing the version in the package.js

3

Here’s what I see in /myWebApp/packages/accounts-base/3.2.0-beta340.11/package.js . I copied the package files from myUserName/.meteor/packages/accounts-base/3.2.0-beta340.11 :

// This file is included for compatibility with the Meteor 0.6.4 package downloader.

What should I change it to? Or possibly I’ve got the wrong code for the package somehow.

5

An option is use meteor’s source to run your app

you have a few options:

  1. METEOR_CHECKOUT_PATH=.../meteor/meteor meteor run
  2. add an alias in your zshrc/bzshrc like alias mymeteor=.../meteor/meteor then call your app using mymeteor run

let me know if you really need to copy accounts to your app

here you can find how to debug meteor’s source, could be useful

6

Thanks very much for the link, @italojs. I’ve been curious about this for a long time.