Ecmascript 0.12.4 breaks app

lweidig · December 13, 2018, 2:44pm

We recently decided to update our installed packages to the latest release as we do every so often. We are running meteor 1.8.0.1 and the latest ecmascript package breaks things for us. With NO code changes we have some code similar to:

export const MyCronJob = {
  name: 'MyCronJob',
  schedule: parser => parser.text('every 1 hour'),
  job: async () => {
    ....
    const result = await myfunction(testVal);
    ...
  }
}

With 0.12.3 this builds just fine and the application runs properly. With 0.12.4 the app no longer runs and during build we get: await is a reserved word. Fortunately just reverting to 0.12.3 gets things back up and running. Any thoughts why this breaks? Should I just submit an issue under the main meteor git?

robfallows · December 13, 2018, 3:17pm

Are you updating to the Meteor 1.8.1 (currently still in beta) version of ecmascript while remaining with Meteor 1.8.0.1?

If so, that seems like an expected risk of breakage. Meteor has traditionally released versions based on a curated and tested-as-working set of packages. Trying to jump the gun, especially with something as touchy as Babel, does not sound like a good idea.

lweidig · December 13, 2018, 4:00pm

No, it pulled this version simply with meteor update being run and remained at 1.8.0.1

robfallows · December 13, 2018, 4:13pm

Hmm. That does sound unexpected. The ecmascript version in 1.8.0.1 is definitely set to 0.12.3:

github.com

meteor/meteor/blob/release-1.8.0.1/packages/ecmascript/package.js#L3


Package.describe({
name: 'ecmascript',
version: '0.12.3',
summary: 'Compiler plugin that supports ES2015+ in all .js files',
documentation: 'README.md'
});


Package.registerBuildPlugin({
name: 'compile-ecmascript',
use: ['babel-compiler'],
sources: ['plugin.js']
});

lweidig · December 13, 2018, 4:27pm

Ok, not going to argue about this. I know it was meteor update followed by broke. In fact after forcing it back to 0.12.3 if I run the same command again I get:

$ meteor update
This project is already at Meteor 1.8.0.1, the latest release.
Your top-level dependencies are at their latest compatible versions.
                                              
The following top-level dependencies were not updated to the very latest version available:
 * ecmascript 0.12.3 (0.12.4 is available)

robfallows · December 13, 2018, 4:59pm

I wasn’t arguing, I was expressing confusion

robfallows · December 13, 2018, 5:20pm

I just tried the same update on a 1.8.0.1 project and can confirm that ecmascript and a few other packages are updated to the current devel branch versions. However, I don’t get any problems with using async/await

lweidig · January 10, 2019, 7:28pm

Well made the mistake of going to 1.8.0.2 today as the system suggested, once again BROKEN! However, this time it will not let me downgrade ecmascript to 0.12.3 as there appears to be some root level dependency on the 0.12.4 version. Man, meteor updates are frustrating! Any suggestions now why the code is broken syntax wise.

macrozone · January 11, 2019, 11:43am

do you have a custom babel config? can you share it?

lweidig · January 11, 2019, 1:29pm

Actually, it appears the older versions were not processing the statements correctly. We had that await inside of a forEach((item) => {{) loop and it was simply necessary to move the async in front of (item) for it to work and compile correctly.

We do not have a custom babel config either. Thanks for the help!