In trying to upgrade my project to Meteor 1.2 on mobile i’ve run into an issue converting the plugin repo urls over.
To add a cordova plugin from a git repo Meteor documentation says:
meteor add cordova:com.phonegap.plugins.facebookconnect@https://github.com/Wizcorp/phonegap-facebook-plugin.git#5dbb1583168558b4447a13235283803151cb04ec
So I tried that with a plugin I was currently using before Meteor 1.2 which is here: https://github.com/xmartlabs/cordova-plugin-market . Which adding it should give me:
meteor add cordova:com.xmartlabs.cordova.market@https://github.com/xmartlabs/cordova-plugin-market.git#4421fffe9d3feba07c081dfd6c20c815ba81deb9
However when I build for android / ios I get an error that it couldn’t be found or the plugin spec is incorrect. The weird thing is when I go back and look at the plugin added via meteor list I see:
cordova:com.xmartlabs.cordova.market https://github.com/xmartlabs/cordova-plugin-market.git (Without the prepending slash which indicated which commit to checkout).
And indeed if I go back to look at how cordova-update was built, which comes from a git repo, meteors console looks like:
Adding plugin https://github.com/meteor/com.meteor.cordova-update.git#16c53f53e438fc8b1b9c768de36f0a8974e38b49 to Cordova projecthttps://github.com/meteor/com.meteor.cordova-update.git ” via git clonehttps://github.com/meteor/com.meteor.cordova-update.git ” checked out to git ref “16c53f53e438fc8b1b9c768de36f0a8974e38b49”.
While the error’d plugin looks like:
Adding plugin com.xmartlabs.cordova.market@https://github.com/xmartlabs/cordova-plugin-market.git to Cordova projecthttps://github.com/xmartlabs/cordova-plugin-market.git ” via npmhttps://github.com/xmartlabs/cordova-plugin-market.git ” via cordova plugins registry
While adding plugin com.xmartlabs.cordova.market@https://github.com/xmartlabs/cordova-plugin-market.git to Cordova project:https://github.com/xmartlabs/cordova-plugin-market.git via registry.
Notice it didnt try and fetch the specific commit. What gives.
2 Likes
Hmmm, confirmed this is a bug. Unfortunately, directly adding a Cordova plugin (meteor add) with a Git URL doesn’t work because the part after # will be removed when reading cordova-plugins. As this bug does not affect plugin dependencies in packages specified using Cordova.depends, a workaround is to create a local package.
A fix should be in the next point release.
3 Likes
@martijnwalraven
Yep you are correct. Cordova.depends works that way just fine. I actually found a work around to this for the command line. I noticed that Meteor automatically tried to convert all my cordova git urls to the new format. If you go back and remove the offending plugins with the bad git urls and then re-add them with the old style git urls they still work.
For instance
meteor add cordova:com.xmartlabs.cordova.market@https://github.com/xmartlabs/cordova-plugin-market/tarball/4421fffe9d3feba07c081dfd6c20c815ba81deb9
Still works for now.
occasl
September 23, 2015, 12:32am
4
As of version 1.2.0.1, the tarball URL no longer works. I’m seeing this error:
➜ 5:08PM ma-cordova git:(develop) ✗ meteor add cordova:com.xxx.qaps.mobile.plugin.phone@https://github.xxx.com/lsacco/cordova-phone/tarball/a6954116419107014165b7ae093b656203d9c0cf https://github.xxx.com/lsacco/cordova-phone/tarball/a6954116419107014165b7ae093b656203d9c0cf .
=> Started proxy.
While installing Cordova plugins:https://github.xxx.com/lsacco/cordova-phone/tarball/a6954116419107014165b7ae093b656203d9c0cf.)
=> Your application has errors. Waiting for file change.
Ah yes, I forgot. I actually added them to the .meteor/cordova-plugins file directly. I didn’t go through meteor add [plugin].
1 Like
occasl
September 23, 2015, 9:56pm
6
I was able to add them using meteor add.
First, I cloned the git project under myapp/private folder. It’s important it’s private otherwise Meteor will pick-up the www/*.js files and try to compile like normal causing other issues (e.g., “module” or “require” is not defined).
Second, use the following command to add them to your project:
meteor add cordova:com.loutilities.qaps.mobile.plugin.phone@file://./private/plugins/cordova-plugin-phone
This will them to the cordova-plugins directory along with the other bits they add.
Thanks! I was having the same problem and this seemed to do the trick to get it to run at least (doesn’t work for me yet, but that’s up next).
@martijnwalraven cool. Is there an early release we could test this with?
This should be fixed in the current release, Meteor 1.2.0.2.
@martijnwalraven thanks. I am running 1.2.0.2
So do you mean you still have issues with this?
Yes. The error I mentioned before.
Adam Ginsburghttp://buzzy.buzz
Could you elaborate on this? What error specifically do you encounter with 1.2.0.2, and what seems to trigger it?
@martijnwalraven oops, was answering via email… too many threads https://github.com/raix/push/issues/120
Ok, I responded on the linked issue.
please see this for details: