Feedback needed: simple:rest compat

packages
#1

Hi, I’ve started updating the packages from simple org.

They are basically around REST features.

To be compatible with Meteor 2.4 I’d to update a the connect NPM dependency and I also had to add new npm dependencies.

If you are using this package in your app I would like your feedback.

I don’t have any real app with this package, this is why your feedback is really important in this case.

Important changes:
simple:json-routes
simple:rest

If you are not getting what is Meteor Compat packages, read here.

This compat package was started because of this request.

3 Likes
#2

Hi,

we are using the simple:json-routes packages and getting an error lately with the new version (2.3.0) and Meteor v2.4.

W20211012-11:15:17.931(2)? (STDERR) Tue, 12 Oct 2021 09:15:17 GMT body-parser deprecated undefined extended: provide extended option at packages/simple_json-routes.js:33:39

This can be reproduced by simply creating a new meteor 2.4 project and adding the simple:json-routes package.

meteor create --bare repro-meteor-simple-json-routes && cd repro-meteor-simple-json-routes
meteor add simple:json-routes
meteor run

The problematic line seems to be this one:

WebApp.connectHandlers.use(bodyParser.urlencoded({limit: '50mb'})); //Override default request size

Do you have any idea how to fix this?

Greetings.

#3

I am having the same issue here.

#4

I copied the json-routes in my packages folder and changed that line to:

WebApp.connectHandlers.use(bodyParser.urlencoded({limit: '50mb', extended: false})); //Override default request size

I’m not sure what the advantage of either true or false is exactly?

The extended option allows to choose between parsing the URL-encoded data with the querystring library (when false) or the qs library (when true). The “extended” syntax allows for rich objects and arrays to be encoded into the URL-encoded format, allowing for a JSON-like experience with URL-encoded.

#5

Hi, could you open a PR here with your solution?

I believe it’s better to pass false to avoid depending on another library.

Thanks.

#6
#7

Thank you.

Published simple:json-routes@2.3.1.

2 Likes