Generators broken due to standard-minifiers?


#1

Hey - I have a project: https://github.com/deanius/meteor-promise, which use JS generators (function* ()), and whose tests pass when run via meteor test-packages ./

However, tests fail in Spacejam, and I can’t deploy because the standard-minifiers package complains about the * used to define the generator function.

/Users/deanius/.meteor/packages/standard-minifiers/.1.0.1.1lit17x++os+web.browser+web.cordova/plugin.minifyStd.os/npm/minifiers/node_modules/uglify-js/lib/parse.js:196:18:
Unexpected token operator «*», expected punc «(»
at new JS_Parse_Error

Is this a bug in standard-minifiers ? Again - runs fine locally, passes tests, but won’t deploy. Feels like a build system problem to me.


#2

This is because the minifier parses all of code, and must be using a parser that doesn’t support generators. Perhaps we should switch parsers, or upgrade!


#3

@deanius having this problem with your package deanius:promise


#4

Same problem here, is there any workaround?


#5

meteor update deanius:promise

I released 3.1.3 to allow this to work, relaxing some checks to workaround Meteor’s minifier. Hopefully @sashko can get the minifier patch routed somewhere internally