I’m on a Yoga 15" 730, which is their mid-range tier - it was less than half the cost of a similar MacBook Pro (similar RAM/SSD/GPU), and has a fast large SSD, and a dGPU (GTX 1050), and the hardware feels solid (almost a MacBook quality, but not quite).
The only problem I’ve had with it, is that it runs Windows! The command line is terrible compared with any *NIX terminal, and WSL is only partly workable (other bash on Windows suffer from still being Windows underneath) - chocolatey is not what you’d hope for (it’s not homebrew or aptitude). Various other things just don’t run well on Windows (Adobe’s stuff, multiple monitor support - though that’s much improved from a few years ago, I haven’t tried high color gamut yet, but it was always really hard to get that right on Windows, and other little annoyances). There isn’t any real way to run a sudo-less like Windows setup - too many things require admin privs - and the means you need IO blocking (SLOW) software like Windows Defender to avoid viruses. There just isn’t a good email client on Windows that I can find (not a problem if you use gmail of course). On the other hand, there are some things Windows does better - it’s scale model for non-powers of two sized screen DPIs is better, it has a touch screen, which is great for mobile dev - I actually can’t think of anything else. Gaming is better of course, but I’m mostly talking about workstation aspects in this case.
The real biggest problem is that Meteor has some catastrophic work flow breaking performance problems on Windows. I run it in a VM to work around that problem - it’s seriously that slow (less than 10 second rebuilds inside VM - 100+ seconds rebuilds in Windows!). At some point I’ll probably switch to Ubuntu and run that from boot. Windows hasn’t been terrible enough that I have to stop everything to do that though, so that’s worth noting. It’s only Meteor that runs so slowly.
As far as hardware more broadly - Windows vendors have largely caught up to Apple in terms of quality, IMHO. If you want to spend Apple sorts of money, you’ll get hardware as good or better than MacBook Pro with more options (Razer Blades are gorgeous, or higher end work station Lenovo units, or Surface Book with dGPU) - and if you want to spend less (in my case, LESS THAN HALF) you can get hardware almost as good, with nothing comparable in the Apple line up. For (less than) half the cost, almost as good is good enough for me - and I get to have my function keys and full USB and HDMI ports!
I just wish Meteor ran better on Windows…
(It should go without saying, but if you still need to publish iOS or macOS apps - you are locked in to Apple hardware. In my case, I spent so much less on my replacement PC, I’ll probably pick up a cheap Mac Mini or MacBook Air for any kind of iTunes connect work I need to do, and will still have spent less overall than buying a replacement MacBook Pro.)