Github pull request


#1

I am trying to create a pull request. So I filled out the contributor agreement, but when ever I try to create the pull request it tells me

Authentication Failed
You may not have permission to access meteor. Check Preferences to make sure you’re still logged in

Now this sounds pretty straight forward, yet I am logged into my github account alright, since I can write to my own repositories.

Is there a step I am missing?


#2

Have you followed these directions? https://help.github.com/articles/creating-a-pull-request/


#3

I think so, but I don’t seem to be able to create a branch.


#4

Did you fork the repository?


#5

That was my missing step. I had cloned it to my home directory, but hadn’t forked it. Doing it now. Thanks a lot


#6

I hope I did it right this time: here is my pull request


#7

Probably just due to getting lost in the UI, but you have submitted the PR on your own fork. Submit to the Meteor devel branch here:

Also, when commenting the PR, just type ‘#3959’ to get a nice cross-link to the issue


#8

Thanks. In hindsight it doesn’t make sense to create a pull request against my own fork, I realize. It was late and Sierra Nevada was over to party.