alawi
October 31, 2019, 11:13am
18
Wow, bkmarke looks impressive!
I’ve not used MUI react yet but I’ve used FM7 and I want to experiment with Ionic 4 (will share with the community when I get something going), I’m still unable to find good samples for Ionic 4 since it is relatively new so I’m not sure how accurate their claim is about being mobile optimized. I might be a good step for Meteor and maybe supporting the react/vue native frameworks and cordova is a better approach, but what also got me interested in ionic 4 is that it is based on web components which might have longer lifespan that other frameworks. I just wanted to point out that there might be potential of integration with Meteor and it also good to keep an eye on that community.
Sorry for going off on a tangent.
1 Like
Congratulations @filipenevola ! This is the best news in a while. I’m so positive now about the future of Meteor.
5 Likes
Congratulations @filipenevola . We’re witnessing something welcoming, game-changing, groundbreaking and heartwarming in the Meteor community - and I am very happy with all latest development (Tiny acquisition) and I wanna really say a big thankful for all those who stood and continued supporting Meteor and the community.
6 Likes
rjdavid
October 31, 2019, 2:39pm
21
Great to see a familiar name to be working with Meteor. Congrats @filipenevola
By the way, I just sent this to my team earlier today
5 Likes
Great @rjdavid .
Thanks @illustreets and @martineboh . We are going to make great things together Meteor community is incredible.
7 Likes
Congratulations, @filipenevola , I’m so glad for you.
Brazilian’s developers community is growing up to worldwide.
1 Like
Congratz @filipenevola , happy to see such move…
1 Like
This is amazing! Congratulations.
5 Likes
Saksi
October 31, 2019, 8:46pm
27
Congratulations @filipenevola . Really good news! Can’t wait to see what magics you can do for the community
2 Likes
orloff
November 1, 2019, 6:22am
28
Meteor community is unique and very active, looks promising!
2 Likes
jorgeer
November 1, 2019, 10:29am
29
Great to hear! You are very much needed here @filipenevola Looking forward to seeing where we are going next
2 Likes
seba
November 4, 2019, 11:22am
30
Congrats! Glad to see Tiny taking its first actions.
filipenevola:
or a not responded PR
I can think of about 57 of those
3 Likes
Yeah, I know, we are going to improve this together. Please list here the ones that you think are still valid if possible starting from the most important ones.
1 Like
My top 2 are:
meteor:devel
← CaptainN:hooks-plus-ultra
opened 04:07PM - 26 Jul 19 UTC
This PR is a roundup of the discussion (and builds on the work) in #262 and #271… , and supersedes: #242, #252, #256, #263, #266, #267, #268.
It does the following:
- Create a base hook, `useTracker` to for use as an alternative to withTracker in hooks based projects.
Rewrites `withTracker` on top of `useTracker` (issues #256, #252, #242 / PR #261)
- Updates docs!
- Removes deprecated createContainer.
- Above #262, this PR retains the synchronous rendering behavior in `withTracker` and in `useTracker` if no deps are specified, but also allows asynchronous reactivity after `firstRun` if deps are supplied, and properly responds to deps changes. This implementation is [compatible with Concurrent Mode, React Suspense and Error Boundaries](https://github.com/meteor/react-packages/pull/271#issuecomment-518414448).
- I wrote new TinyTests for the hook, and ported back the old ones.
- Above #271, this PR fixes a number of issues raised in that PR.
- It also switches the underlying deps compare functionality from a fork of React internals to using `useRef`. There was some concern that results from that may be randomly tossed, but for now (react 16.8.6) they are stable. Even if they are tossed, the only effect this will have on our implementation is that it'll recreate the computation on the next render.
- This PR also adds a third param to the hook, which is a computation lifecycle hook. This method is structured like the method passed to `useEffect`. The main function runs when a new computation is created (before `reactiveFn`) and then if it returns a function, that function is run right before the computation is destroyed. I don't know if this is really all that useful in real world use cases, but it is useful for testing some internal behaviors. I left it undocumented for now.
- This PR also now passes a reference to the current computation to the `reactiveFn`.
- Compatible with SSR.
Since this bumps the react version requirement to 16.8, there has been some discussion about how to properly release this with a major version bump. One suggestion was to bump the old version to 1.0.0 which can receive updates separately, then release this update as 2.0.0.
I believe this is ready for review. (Third time's a charm!)
CC @hwillson @menelike @yched
meteor:master
← meteor:release-1.8.2
opened 04:40PM - 10 Apr 19 UTC
Meteor 1.8.1 has been released and recommended 🎉 🌮 💫, and (as always) the outsta… nding issues/features fall into two categories:
* those we can fix/implement by releasing updates to Meteor packages ([Package patches](https://github.com/meteor/meteor/milestone/40)), and
* those that will require a follow-up Meteor release, because they involve changes to the `meteor/tools` codebase (including the dev bundle), or because they involve significant changes to core packages that we want to avoid releasing until the next Meteor release.
Meteor 1.8.2 (this PR) will bundle up any urgent bug fixes or minor improvements that require a new Meteor release. Feel free to target the `release-1.8.2` branch instead of `devel` with any PRs that seem to fit this description, or we can help you make that decision if you're unsure.
As anyone following Meteor development recently will realize, community input matters a LOT when it comes to deciding what goes into a release, and when it's time to stabilize/finalize it. We welcome that input, and we will do our best to release Meteor 1.8.2 as soon as it's clear it solves specific real problems for Meteor developers.
There will also soon be a Meteor 1.9 pull request for more experimental changes, such as (potentially, but not limited to) upgrading Node.js. Let us know if you think we've mistakenly put something into the [1.9 Milestone](https://github.com/meteor/meteor/milestone/65) that belongs in 1.8.2, or vice-versa!
There is a lot of small and simple ones for which a quick review should be enough to get them merged. For example:
meteor:devel
← StorytellerCZ:facebook-api-update
opened 12:27PM - 14 Oct 19 UTC
Updates Facebook API endpoints to v4. There are no changes in this regards since… v3 upgrade. As far as I have tested everything went smoothly.
meteor:release-1.8.2
← arggh:patch-1
opened 08:05AM - 21 Sep 19 UTC
Better late than never, right?
meteor:devel
← imba-tjd:patch-1
opened 03:30AM - 09 Oct 19 UTC
<!--
First, 🌠 thank you 🌠 for taking the time to consider a contribution to Met… eor!
Here are some important details to follow:
* ⏰ Your time is important
To save your precious time, if the contribution you are making will take more
than an hour, please make sure it has been discussed in an issue first.
This is especially true for feature requests!
* 💡 Features
Feature requests can be created and discussed by visiting:
https://github.com/meteor/meteor-feature-requests/issues
* 🕷 Bug fixes
These can be created and discussed in this repository. When fixing a bug,
please _try_ to add a test which verifies the fix. If you cannot, you should
still submit the PR but we may still ask you (and help you!) to create a test.
* 📖 Contribution guidelines
Always follow https://github.com/meteor/meteor/blob/master/CONTRIBUTING.md
when submitting a pull request. Make sure existing tests still pass, and add
tests for all new behavior.
* ✏️ Explain your pull request
Describe the big picture of your changes here to communicate to what your
pull request is meant to accomplish. Provide 🔗 links 🔗 to associated issues!
We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment.
-->
meteor:devel
← gabrielmcoelho:patch-1
opened 04:07PM - 15 Oct 19 UTC
Since variables defined with **const** are not supposed to be reassigned, 'succe… ss = false' could cause errors. Changed declaration to **let** to avoid that.
<!--
First, 🌠 thank you 🌠 for taking the time to consider a contribution to Meteor!
Here are some important details to follow:
* ⏰ Your time is important
To save your precious time, if the contribution you are making will take more
than an hour, please make sure it has been discussed in an issue first.
This is especially true for feature requests!
* 💡 Features
Feature requests can be created and discussed by visiting:
https://github.com/meteor/meteor-feature-requests/issues
* 🕷 Bug fixes
These can be created and discussed in this repository. When fixing a bug,
please _try_ to add a test which verifies the fix. If you cannot, you should
still submit the PR but we may still ask you (and help you!) to create a test.
* 📖 Contribution guidelines
Always follow https://github.com/meteor/meteor/blob/master/CONTRIBUTING.md
when submitting a pull request. Make sure existing tests still pass, and add
tests for all new behavior.
* ✏️ Explain your pull request
Describe the big picture of your changes here to communicate to what your
pull request is meant to accomplish. Provide 🔗 links 🔗 to associated issues!
We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment.
-->
meteor:devel
← sebakerckhof:refactor/accounts-accounts-hashStampedToken
opened 09:02AM - 24 Oct 19 UTC
Found this quite unreadable way of extracting a property from an object.
etc.
I think these small ones should be quickly merged/closed (and also in the future), so that the clutter does not obstruct the more important/complex big ones. After that the next step should be all the Typescript conversions (before or after 1.8.2 release, does not matter).
6 Likes
storyteller:
I think these small ones should be quickly merged/closed (and also in the future), so that the clutter does not obstruct the more important/complex big ones. After that the next step should be all the Typescript conversions (before or after 1.8.2 release, does not matter).
Although I absolutely agree that functional changes should take priority, I would like to add a +1 to reviewing TypeScript conversions (after 1.8.2 is fine). As someone who submitted a few conversion PRs, I kind of lost steam when I had a few PRs that had been hanging out for a while without review, but I’d love to jump back into it if this is still an initiative that Meteor wants to move forward with.
6 Likes
Especially with new TypeScript 3.7
2 Likes
seba
November 7, 2019, 2:47pm
36
I just went over all of them, and all of them seem to still be valid. Of course, for the ones more than a year old, it might be hard getting in touch with the submitter for changes.
1 Like
I’m still just waiting for this :lolsob:
meteor:release-1.8.3
← meteor:avoid-bundling-jquery-twice
opened 04:51PM - 19 Mar 19 UTC
Closes #10289
Previously: #6864, #6626
cc @arggh
4 Likes
@benjamn answered about it https://github.com/meteor/meteor/pull/10498#issuecomment-551541755
I would love to see that merged, but the test failures indicate that the major version bump (to jQuery 3) is causing version solver conflicts. This is no surprise, since packages that depend on jquery almost certainly need to be updated to work with jQuery 3 instead of 1.12.1 (or maybe they can stop using jQuery entirely), but I’m not sure how much work that will take.