Package system changing function parameters

stocksp · September 27, 2015, 11:24pm

Particularly nasty (specific function fails with very unhelpful error message).
Very easy to see and repro.
Meteor is adding a blank space to a function parameter.

In a new project:
meteor add pdftk:pdftk
Run meteor and inspect the pdftk_pdftk.js Meteor package system has generated. It lives in
.meteor/local/build/programs/server/packages.
line 70 has a blank space appended to ‘fill_form’ the second parameter
return PDFTK.execute([pdf, 'fill_form ', xfdf, ‘output’, output], callback);

If you examine the source of the package on GitHub, you can see the original file is fine and not the source of the bad parameter.

github.com

MeteorPackaging/pdftk/blob/master/pdftk-wrapper.js

var execFile = Npm.require('child_process').execFile;

if (PDFTK === undefined)
  PDFTK = {};

/**
 * Execute the PDFTK installed in the system
 * @param  {Array}    args - command-line arguments to pdftk
 * @param  {Function} callback - callback function that receives error, stdout, and stderr
 */
PDFTK.execute = Meteor.wrapAsync(function execute(args, callback) {
  execFile('pdftk', args, {encoding: 'binary', maxBuffer: 1024 * 1000}, function pdftkCallback(error, stdout, stderr) {
    if (error) {
      if (error.code === "ENOENT")
        callback('Could not find pdftk executable');
      else
        callback(error);
    } else {
      callback(null, new Buffer(stdout, 'binary'), new Buffer(stderr, 'binary'));
    }

This file has been truncated. show original

robfallows · September 28, 2015, 9:49am

It looks like the package has been fixed, but has not been published to atmosphere. You could try contacting the package author to encourage a republish!

shock · September 28, 2015, 10:05am

I already added cloning git repo to my local dir as early step in any troubleshooting.
Too many times I looked on github code and felt stupid why something is not working just cause people dont publish updates.

stocksp · September 28, 2015, 2:19pm

Thank you! That must be the problem (they haven’t updated atmosphere. What is ‘funny’ is that this package is suppose to be the ‘official’ one. I will just clone it and use it myself.

garrilla · September 28, 2015, 3:49pm

It might be the ‘official’ one, but that doesn’t guarantee they put meteor package into their build pipeline