I was reading about Sign In With Apple on Mac Rumors. Seems pretty cool.
Anyone else thinking about adding it to their Meteor app? Would be a great addition to accounts
It could prove a popular option with its enhanced security and anonymization features.
2 Likes
cereal
September 27, 2019, 11:52am
2
if itās oauth-like, you should be able to wrap it up with the OAuth package. Lots of third party account packages do that.
I have it somewhere on my list of todos, so if no one beats me to it, I will eventually do it.
2 Likes
jramer
September 28, 2019, 1:13pm
4
I have started on it. Will post when I have something working.
4 Likes
arggh
September 30, 2019, 6:07am
5
Why not take people on board while working on it?
jramer
October 1, 2019, 8:25pm
6
Yes. Youāre right. Iāll share my code and we can figure out the last bit together. For some reason the reply in the redirect from Apple that should contain the code and state is empty but only in my meteor oauth implementation and not if test it on another redirect urlā¦
Repo coming tomorrow. I need some sleepā¦
jramer
October 4, 2019, 11:27am
7
Ok, my tomorrow spanned a few days. Sorry about thatā¦
But I have working code! Still needs some love but it is something to start from.
The biggest problem I had was that the oauth flow in meteor isnāt built for receiving data in the post body. I had to hack oauth_server.js
in the oauth package to allow that. Someone with better knowledge can certainly improve on that code.
The packages are here:
https://github.com/jramer/accounts-apple
https://github.com/jramer/apple-oauth
https://github.com/jramer/apple-config-ui
https://github.com/jramer/meteor/tree/feature/oauth-post-body
Pull request are most welcome!
I have tested it with success in:
desktop chrome
Found out that itās not yet working in:
ios browsers (ios13 doesnāt use the popup, guessing it will be similar in Safari for macos catalina)
Pretty certain that it needs some love before it works in cordova.
6 Likes
jramer
October 5, 2019, 1:23pm
9
yes.
Time to bring out the lightning cable and Safari dev Consoleā¦
The login flow is pretty sweet with faceid/touchid.
1 Like
Sweet! Please consider adding it to linked accounts:
1 Like
jramer
October 5, 2019, 1:43pm
11
Sure. It need some work first though.
Do you have any input on how to best implement the fix for the post body data I mentioned in my post?
I would check Meteor PRs, if I remember correctly there was something along those lines.
1 Like
Ah! Here is the PR that should add that capability:
meteor:devel
ā rooch84:10491-checks-for-post-request-with-oidc-redirect
opened 09:12AM - 20 Mar 19 UTC
ā¦ody.
See #10491
<!--
First, š thank you š for taking the time to considā¦ er a contribution to Meteor!
Here are some important details to follow:
* ā° Your time is important
To save your precious time, if the contribution you are making will take more
than an hour, please make sure it has been discussed in an issue first.
This is especially true for feature requests!
* š” Features
Feature requests can be created and discussed by visiting:
https://github.com/meteor/meteor-feature-requests/issues
* š· Bug fixes
These can be created and discussed in this repository. When fixing a bug,
please _try_ to add a test which verifies the fix. If you cannot, you should
still submit the PR but we may still ask you (and help you!) to create a test.
* š Contribution guidelines
Always follow https://github.com/meteor/meteor/blob/master/CONTRIBUTING.md
when submitting a pull request. Make sure existing tests still pass, and add
tests for all new behavior.
* āļø Explain your pull request
Describe the big picture of your changes here to communicate to what your
pull request is meant to accomplish. Provide š links š to associated issues!
We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment.
-->
2 Likes
jramer
October 29, 2019, 1:52pm
15
Yes itās out and working as intended on chrome, firefox, safari and ios browsers (ie/edge not tested but should work).
I still havenāt had time to look into cordova. Our app is web only and my time is limitedā¦
Started to look at meteor-link-accounts and that is something we need to have working.
3 Likes
If you need help with integrating into link-accounts, let me know, but it should be pretty straight forward.
jramer
October 29, 2019, 2:00pm
17
Thanks!
Yes looks straight forward.
I want to have link-accounts working as intended in our app first and then Iāll create the apple integration.
1 Like
@jramer Is this still working for you? Any new changes?
jramer
March 9, 2020, 12:46pm
19
Yes. I have it running in production.
And my PR has been included in 1.10 which will remove the need to use my fork of the oauth-package.
I still havenāt had the time to look at making it work in Cordova, or with link-accounts.
1 Like
Thanks for your answer! Apple still pushing this for end of April 2020.