[Solved] => Server modified -- restarting

harry73 · February 28, 2024, 6:39pm

Hi,

I have the message in the subject but without any indications about what has been modified.
How can i be able to know that?

It is happened when running on Actions Github.

Thanks

grubba · February 28, 2024, 10:18pm

Hey @harry73, could you mind sharing more data about what happened? Can you provide a reproduction so that we can test on top of it?

harry73 · February 28, 2024, 10:46pm

Hi @grubba ,

Thanks for your answer.
In fact i am running Meteor 3 beta 4 with meteor-vite from @jorgenvatle with vue3. I am trying to setup Cypress tests but when the ‘cypress run’ starts on Github via Actions i have this message and vite restarting also. It happened several times and my tests failed (white screen).
Locally, it works, even by removing the node_modules/.vite folder.

As i do not know if it was working on Meteor 2. The tests are new, i wanted to go deeper in the analyzis (peharps something in my code) before bother you. It was the aim of my question.

I will try to see if i can manage to reproduce the issue on a simple project.

grubba · February 28, 2024, 11:08pm

Maybe it can do something with your global meteor installation(in the CI)

No worries about bothering me; you can always ping us on Slack, and maybe someone there can help, too.

rjdavid · February 29, 2024, 12:35am

The test/action might be creating/updating a file somewhere in your project directory.

jorgenvatle · February 29, 2024, 5:54pm

Hey there. Are you still having issues with this?

harry73 · February 29, 2024, 10:55pm

Hi @grubba, @jorgenvatle

Please check the following repo where I am able to reproduce the issue:

Locally, meteor npm start and then meteor npm test work well.

On Github, it fails.

Thanks

harry73 · March 2, 2024, 5:19pm

Hi @grubba, @jorgenvatle

Did you find something?

Thanks.

jorgenvatle · March 3, 2024, 12:44am

Haven’t yet had the chance to look into it. Wanted to check now, but it seems Atmosphere.js is down at the moment.

I recall having a similar issue when getting the Svelte example set up. Vite would convert your Vite config from .js to a timestamped .mjs file, and Meteor would trigger a restart every time the file was added, in turn creating another .mjs file on next startup.

Thanks for setting up a repo reproducing the issue.

harry73 · March 3, 2024, 5:11am

I tried also to use GitHub - bluwy/vite-plugin-warmup: Warm up Vite's transform cache but the result is the same: locally it is ok, actions github it fails.
For mjs, i think i tried to have the vite config directly in mjs (because of some options) but same result

harry73 · March 8, 2024, 2:53pm

Hi,

Did you have chance to look at it ?

Do you need something from me ?

Thanks

jorgenvatle · March 12, 2024, 9:11am

Hey @harry73.

Just had a few hours to look into it. Seems like Cypress isn’t able to connect to the Vite dev server when running in GitHub Actions. I had similar issues trying to run the repository in GitHub Codespaces. Calling Vite from within the GitHub container works fine, but proxied connections appear to be flaky.

I’ll follow up later this afternoon if anything comes up.

jorgenvatle · March 12, 2024, 12:11pm

Seems like Cypress really doesn’t like it when Vite triggers a client refresh.

Made some changes to try to run dependency optimization before Cypress accesses the app.

The Meteor server restarts were just from summary files being added to your Cypress directory. Excluding them with a .meteorignore file seems to have done the trick there.

I submitted a pull request with what I did so you can get a better insight into what changes were necessary to get it to run.

github.com/harry-73/cypressActions

Fix tests

harry-73:master ← JorgenVatle:fix-tests

opened 12:03PM - 12 Mar 24 UTC

JorgenVatle

+491 -449

The Meteor server restarts were caused by Cypress emitting test summary files to… `./tests/cypress`. Instructing Meteor to ignore the directory resolves the issue. I also went ahead and refactored the caching steps in the test workflow. Meteor's install script (`curl https://install.meteor.com | sh`) only adds a binary to your environment that only installs Meteor when you first use it. Can't say how many hours I've spent debugging this. You'll want to cache both `~/.meteor` as well as the project's `.meteor` directories with their own cache keys. I found that using the `meteor lint` command is best way to force Meteor to install your packages without having to run the dev server first. For Vite, you can specify your client entry file in [`optimizeDeps.entries`](https://vitejs.dev/config/dep-optimization-options.html#optimizedeps-entries) to ensure your entrypoint is optimized before you first load the dev server in your browser. Since Meteor-Vite isn't using the standard `index.html` expected by Vite, we need to explicitly configure the entry module for the app. Though, I had a bit of trouble with the optimizeDeps option, as it would still optimize dependencies at runtime for modules that are dynamically loaded like our stub validation plugin `meteor-vite/client`. But I think with the right caching rules, and maybe as a last resort, hitting the server once with a browser before running tests should resolve those issues.

harry73 · March 15, 2024, 10:40am

Thanks.

Now, the server does not restarted any more on GitHub

On the repo that reproduicing the issue, everything works well.

My project, unfortunately, on Github, the tests are failing.

Locally, everything is OK, but not with GitHub Actions. Il is like the Application is not loaded (white page).

When I look at Cypress Replay, I can see that there is no answers for:

Locally, it is OK:

Also on Actions GitHub, I do not see this request:

harry73 · March 15, 2024, 2:53pm

I forgot to mention. I use:

Meteor 3 beta 6
Vite-bundle 2.0.0 beta 11
Meteor-vite 1.10.2

jorgenvatle · March 16, 2024, 1:52pm

Can you try with jorgenvatle:vite-bundler@2.0.0-beta.12? And let’s set an explicit hostname for the Vite client entry script - set METEOR_VITE_HOST=localhost in your Meteor start script. This should ensure the HTML served by Meteor won’t point the Cypress client to the Vite dev server on an invalid IP.

Also make sure server.host is set to true in your Vite config. I recall this being an issue with default options, even for connections on localhost when running inside of GitHub’s environment.

If there’s no luck with that, would you be able to update the example repo with a way to reproduce the issue?

harry73 · March 17, 2024, 6:18pm

It works!!

Thanks for your time.