[Solved] Upgrading from 1.11 to 2.5 minification error

help
1

Trying to upgrade to 2.5.1 and while the app starts up fine in dev, the minification is failing with a fairly long list of this exact error:

qualia_1            |    While minifying app stylesheet:
qualia_1            | 
qualia_1            |    /opt/app/.meteor/local/isopacks/standard-minifier-css/plugin.minifyStdCSS.os/npm/node_modules/meteor/minifier-css/node_modules/postcss/lib/input.js:24:13:
qualia_1            |    PostCSS received undefined instead of CSS string
qualia_1            |    at new Input
qualia_1            |    (/opt/app/.meteor/local/isopacks/standard-minifier-css/plugin.minifyStdCSS.os/npm/node_modules/meteor/minifier-css/node_modules/postcss/lib/input.js:24:13)
qualia_1            |    at parse
qualia_1            |    (/opt/app/.meteor/local/isopacks/standard-minifier-css/plugin.minifyStdCSS.os/npm/node_modules/meteor/minifier-css/node_modules/postcss/lib/parse.js:8:15)
qualia_1            |    at new LazyResult
qualia_1            |    (/opt/app/.meteor/local/isopacks/standard-minifier-css/plugin.minifyStdCSS.os/npm/node_modules/meteor/minifier-css/node_modules/postcss/lib/lazy-result.js:133:16)
qualia_1            |    at Processor.process
qualia_1            |    (/opt/app/.meteor/local/isopacks/standard-minifier-css/plugin.minifyStdCSS.os/npm/node_modules/meteor/minifier-css/node_modules/postcss/lib/processor.js:36:12)
qualia_1            |    at Object.minifyCss (packages/minifier-css/minifier.js:71:8)
qualia_1            |    at Object.profileWrapper
qualia_1            |    (/root/.meteor/packages/meteor-tool/.2.5.1.vq2kyo.rfuos++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/tools/tool-env/tools/tool-env/profile.ts:265:16)
qualia_1            |    at packages/standard-minifier-css/plugin/minify-css.js:42:36
qualia_1            |    at
qualia_1            |    /root/.meteor/packages/less/.2.7.4.tcyzkx.s5xz++os+web.browser+web.cordova/plugin.compileLessBatch.os/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:32:39
qualia_1            |

I can’t imagine how we’re sending a blank string to the post-processor. Looking online, all the “non meteor” occurrences of this seem to have to do with node-sass, which we don’t use, though we do use less.

With debug enabled I also see (before the above error):

            |      START 2 minifying app stylesheet
            |      DONE 2 minifying app stylesheet took 41
            |      START 2 minifying app stylesheet
            |      DONE 2 minifying app stylesheet took 54
            |      START 2 minifying app code
            |      DONE 2 minifying app code took 1
            |      START 2 minifying app stylesheet
            |      DONE 2 minifying app stylesheet took 460
            |    DONE 1 building for web.browser took 38688

Which would suggest that it worked (though it didn’t) - I also tried downgrading the minifier packages (which didn’t work, they auto-upgraded themselves)

Anyone else come across this?

2

I would recommend upgrading your project one version at a time, reviewing the breaking changes for each release.

3

Turned out we had a custom version of the package installed locally which was causing the problem :frowning: