Using wallaby with Meteor 1.3 and Meteor packages


#1

Hi,

I am trying to get meteor to work with wallaby, so I can do instant feedback on unit testing. Thus far, I have gotten it to work with any meteor module that only uses npm modules. but anything that uses a meteor package is a non-starter because of the magic that meteor does behind the scenes to make packages work.

Here is the repo I created:

and the issue in wallaby where I have been talking to the creator of wallaby to try to get it to work:

My question is: how can I make this kind of code:

import { Meteor } from 'meteor/meteor'

export default function stuff(arg) {
  return `${arg} there`
}

testable? Currently, I’ve gotten it to load the meteor.js in packages/ that meteor generates, but it relies on a huge amount of magical assumptions of things existing that don’t exist unless inside meteor. wallaby runs outside meteor, so…

Is this possible?


#2

Did you see https://github.com/xolvio/automated-testing-best-practices?

Currently I’m only using Wallaby for “pure” module testing, but if I understood correctly, the wallaby config files from this repo get (parts of?) the Meteor environment working correctly inside Wallaby.

Not 100% sure so please report back either way :slight_smile:

@Sanjo you did this, right?


#3

Hi,

I am aware of that repo. It does not work with meteor 1.3 (most recent bug
describes the errors).

What does work is a from-scratch mantra app based on the blog example. But
to make it work, all of the meter packages are mocked and all dependencies
injected.

This is not bad on its face but means integration testing can only be done
through other means.

Sent using CloudMagic Email
[https://cloudmagic.com/k/d/mailapp?ct=pa&cv=8.4.40&pv=5.1.1&source=email_footer_2]


#4

@gadicc you’re correct, it loads the full Meteor context (including a database when you have one running). It’s definitely a little slower for wallaby to reload the tests, but we’re still talking less than 1 second usually. Wallaby has some good caching and parallelization going on which helps a lot.

I’m sure @sanjo has more to say about that :slight_smile:

@cellog we’ve been hyper busy recently but we’ll get back on that repo and update it soon


Improving coding productivity
#5

Excellent! One note: I have been corresponding with the creator of wallaby
through an issue on their public github, and he noted that adding
"instrument: false" to the packages from meteor can vastly improve the
speed. I tested this and found it reduced load time by more than a second
on my machine. It doesn’t fix the other errors, but is a simple way to
remove that bottleneck.

This basically causes wallaby not to record code coverage for the packages,
or parse the files at all beyond what babel does with them.

Sent using CloudMagic Email
[https://cloudmagic.com/k/d/mailapp?ct=pa&cv=8.4.40&pv=5.1.1&source=email_footer_2]


#6

@cellog simply stubbing out meteor packages is not an solution?

I wrote about how to do it in the topic linked to below. I find it a very good way to work with.


#7

My personal experience is that stubbing means programming in assumptions about how a package works. It allows you to strictly test your code, but does not actually verify that you haven’t broken the connection to the package you are using.

When I was working in PHP, I had a website go down with all tests passing and full coverage for this exact reason.

What I have been doing is using wallaby only for unit tests, and using meteor test for the others. This means I always have 4 processes running in webstorm:

The meteor app
Meteor test
Wallaby
React storybook

Which is OK, I guess. But I really like the instant feedback for wallaby. It’s quite a bit slower to wait for meteor test to refresh.


#8

I have finally updated the wallaby_server.js for Meteor 1.3. I have also added documentation at the top of the file and restructured the code to be easier to use. Let me know if you still have trouble using it.


#9

Hey @Sanjo, finally got around to trying the script today but I get the following error:

Error: Command failed: meteor node -e "process.stdout.write(process.execPath)"
/usr/local/bin/meteor: line 29: HOME: unbound variable
    at checkExecSyncError (child_process.js:470:13)
    at Object.execSync (child_process.js:510:13)
    at Object.<anonymous> (/Users/josh/Projects/name/codebase/.wallaby_server.js:16:4)

I checked process.env.HOME prints out the correct path when running meteor node, which it does.

I instead changed nodePath to '/usr/local/n/versions/node/0.10.43/bin/node'; which seems to have worked, however I still recieve:

Error: Cannot find module 'meteor/meteor'
at server/modules/name/sessions.js:4:0

#10

I experienced the same issue when running wallaby with that wallaby_server.js file - it’s not able to require any meteor module. I further found it was not able to load any local modules referenced by full path, e.g. require("/imports/api/mymodule/collection") it was only able to load relative references.
@Sanjo I would be happy to try and help fix but have to confess I don’t understand what the bootstrap function does - is there any chance you would be willing to explain the essence of what it does, which might enable me to attempt a fix?


#11

I have created an issue related to this on here https://github.com/xolvio/automated-testing-best-practices/issues/59